Merge lp://staging/~gary/juju-gui/testclean into lp://staging/juju-gui/experimental
Proposed by
Gary Poster
Status: | Merged |
---|---|
Merged at revision: | 522 |
Proposed branch: | lp://staging/~gary/juju-gui/testclean |
Merge into: | lp://staging/juju-gui/experimental |
Diff against target: |
429 lines (+72/-31) 12 files modified
Makefile (+20/-10) app/app.js (+2/-1) app/modules-prod.js (+0/-4) app/store/charm.js (+0/-1) bin/merge-files (+1/-2) test/index.html (+1/-1) test/test_app.js (+37/-10) test/test_app_hotkeys.js (+1/-0) test/test_application_notifications.js (+3/-1) test/test_endpoints.js (+2/-0) test/test_notifications.js (+3/-0) test/test_routing.js (+2/-1) |
To merge this branch: | bzr merge lp://staging/~gary/juju-gui/testclean |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Juju GUI Hackers | Pending | ||
Review via email:
|
Description of the change
Make tests more reliable
- When an app is instantiated, always make the connection a no-op if possible to prevent unnecessary additional postponed calls.
- When an app is instantiated, always set the view to a no-op view to prevent routing.
Those two fixes prevent intermittent errors that have been showing up on CI and killing our runs when Canonistack isn't doing that for us.
- Change the compressed file to be called modules.js. This contains all of the modules, rather than pointing to them, as it does in devel/debug. This makes our tests pass in individual suites now.
To post a comment you must log in.
Reviewers: mp+157941_ code.launchpad. net,
Message:
Please take a look.
Description:
Make tests more reliable
- When an app is instantiated, always make the connection a no-op if
possible to prevent unnecessary additional postponed calls.
- When an app is instantiated, always set the view to a no-op view to
prevent routing.
Those two fixes prevent intermittent errors that have been showing up on
CI and killing our runs when Canonistack isn't doing that for us.
- Change the compressed file to be called modules.js. This contains all
of the modules, rather than pointing to them, as it does in devel/debug.
This makes our tests pass in individual suites now.
https:/ /code.launchpad .net/~gary/ juju-gui/ testclean/ +merge/ 157941
(do not edit description out of merge proposal)
Please review this at https:/ /codereview. appspot. com/8580046/
Affected files: app_hotkeys. js application_ notifications. js endpoints. js notifications. js routing. js
M Makefile
A [revision details]
M app/app.js
M app/modules-prod.js
M app/store/charm.js
M bin/merge-files
M test/index.html
M test/test_app.js
M test/test_
M test/test_
M test/test_
M test/test_
M test/test_