Code review comment for lp://staging/~gary/juju-gui/testclean

Revision history for this message
Gary Poster (gary) wrote :

Reviewers: mp+157941_code.launchpad.net,

Message:
Please take a look.

Description:
Make tests more reliable

- When an app is instantiated, always make the connection a no-op if
possible to prevent unnecessary additional postponed calls.
- When an app is instantiated, always set the view to a no-op view to
prevent routing.

Those two fixes prevent intermittent errors that have been showing up on
CI and killing our runs when Canonistack isn't doing that for us.

- Change the compressed file to be called modules.js. This contains all
of the modules, rather than pointing to them, as it does in devel/debug.
  This makes our tests pass in individual suites now.

https://code.launchpad.net/~gary/juju-gui/testclean/+merge/157941

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/8580046/

Affected files:
   M Makefile
   A [revision details]
   M app/app.js
   M app/modules-prod.js
   M app/store/charm.js
   M bin/merge-files
   M test/index.html
   M test/test_app.js
   M test/test_app_hotkeys.js
   M test/test_application_notifications.js
   M test/test_endpoints.js
   M test/test_notifications.js
   M test/test_routing.js

« Back to merge proposal