juju-gui

Merge lp://staging/~gary/juju-gui/testclean into lp://staging/juju-gui/experimental

testclean
Merge into trunk

Proposed by Gary Poster on 2013-04-09

Status:	Merged
Merged at revision:	522
Proposed branch:	lp://staging/~gary/juju-gui/testclean
Merge into:	lp://staging/juju-gui/experimental
Diff against target:	429 lines (+72/-31) 12 files modified Makefile (+20/-10) app/app.js (+2/-1) app/modules-prod.js (+0/-4) app/store/charm.js (+0/-1) bin/merge-files (+1/-2) test/index.html (+1/-1) test/test_app.js (+37/-10) test/test_app_hotkeys.js (+1/-0) test/test_application_notifications.js (+3/-1) test/test_endpoints.js (+2/-0) test/test_notifications.js (+3/-0) test/test_routing.js (+2/-1)
To merge this branch:	bzr merge lp://staging/~gary/juju-gui/testclean
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Juju GUI Hackers		2013-04-09	Pending
Review via email: mp+157941@code.staging.launchpad.net

Description of the change

Make tests more reliable

- When an app is instantiated, always make the connection a no-op if possible to prevent unnecessary additional postponed calls.
- When an app is instantiated, always set the view to a no-op view to prevent routing.

Those two fixes prevent intermittent errors that have been showing up on CI and killing our runs when Canonistack isn't doing that for us.

- Change the compressed file to be called modules.js. This contains all of the modules, rather than pointing to them, as it does in devel/debug. This makes our tests pass in individual suites now.

https://codereview.appspot.com/8580046/

Revision history for this message

Gary Poster (gary) wrote on 2013-04-09:

Reviewers: mp+157941_code.launchpad.net,

Message:
Please take a look.

Description:
Make tests more reliable

- When an app is instantiated, always make the connection a no-op if
possible to prevent unnecessary additional postponed calls.
- When an app is instantiated, always set the view to a no-op view to
prevent routing.

Those two fixes prevent intermittent errors that have been showing up on
CI and killing our runs when Canonistack isn't doing that for us.

- Change the compressed file to be called modules.js. This contains all
of the modules, rather than pointing to them, as it does in devel/debug.
This makes our tests pass in individual suites now.

https://code.launchpad.net/~gary/juju-gui/testclean/+merge/157941

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/8580046/

Affected files:
   M Makefile
   A [revision details]
   M app/app.js
   M app/modules-prod.js
   M app/store/charm.js
   M bin/merge-files
   M test/index.html
   M test/test_app.js
   M test/test_app_hotkeys.js
   M test/test_application_notifications.js
   M test/test_endpoints.js
   M test/test_notifications.js
   M test/test_routing.js

Revision history for this message

Madison Scott-Clary (makyo) wrote on 2013-04-09:

LGTM - should be much cleaner, thanks!

https://codereview.appspot.com/8580046/diff/1/Makefile
File Makefile (right):

https://codereview.appspot.com/8580046/diff/1/Makefile#newcode157
Makefile:157: @echo "test-prod-server: run tests in the browser from the
prod environment"
Very big +1 :)

https://codereview.appspot.com/8580046/

Revision history for this message

Gary Poster (gary) wrote on 2013-04-09:

*** Submitted:

Make tests more reliable

- When an app is instantiated, always make the connection a no-op if
possible to prevent unnecessary additional postponed calls.
- When an app is instantiated, always set the view to a no-op view to
prevent routing.

Those two fixes prevent intermittent errors that have been showing up on
CI and killing our runs when Canonistack isn't doing that for us.

- Change the compressed file to be called modules.js. This contains all
of the modules, rather than pointing to them, as it does in devel/debug.
This makes our tests pass in individual suites now.

R=matthew.scott
CC=
https://codereview.appspot.com/8580046

https://codereview.appspot.com/8580046/