Code review comment for lp://staging/~gary/juju-gui/testclean

Revision history for this message
Gary Poster (gary) wrote :

*** Submitted:

Make tests more reliable

- When an app is instantiated, always make the connection a no-op if
possible to prevent unnecessary additional postponed calls.
- When an app is instantiated, always set the view to a no-op view to
prevent routing.

Those two fixes prevent intermittent errors that have been showing up on
CI and killing our runs when Canonistack isn't doing that for us.

- Change the compressed file to be called modules.js. This contains all
of the modules, rather than pointing to them, as it does in devel/debug.
  This makes our tests pass in individual suites now.

R=matthew.scott
CC=
https://codereview.appspot.com/8580046

https://codereview.appspot.com/8580046/

« Back to merge proposal