lp://staging/~gary/juju-gui/testclean

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/juju-gui/experimental at revision 522

Juju GUI Hackers: Pending requested 2013-04-09

Diff: 429 lines (+72/-31)

12 files modified

Makefile (+20/-10)
app/app.js (+2/-1)
app/modules-prod.js (+0/-4)
app/store/charm.js (+0/-1)
bin/merge-files (+1/-2)
test/index.html (+1/-1)
test/test_app.js (+37/-10)
test/test_app_hotkeys.js (+1/-0)
test/test_application_notifications.js (+3/-1)
test/test_endpoints.js (+2/-0)
test/test_notifications.js (+3/-0)
test/test_routing.js (+2/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

517. By Gary Poster on 2013-04-09

merge trunk

516. By Gary Poster on 2013-04-08

lint plus a bit more cleanup

515. By Gary Poster on 2013-04-08

make tests pass in isolation in prod mode on browser, and add convenience Makefile target for browser prod mode tests.

514. By Gary Poster on 2013-04-08

fix some intermittent test failures by making app instantiation a bit cleaner

513. By Richard Harding on 2013-04-08

Trivial: swap default value up above summary.

R=
CC=
https://codereview.appspot.com/8519043

512. By Richard Harding on 2013-04-08

Add in the 'useful links' side column.

- Pull Huw's branch that adds the column.
- Since the view/template is shared between fullscreen/sidebar views it needs
to toggle on/off.
- Add tests for the isFullscreen added to the template.

R=jeff.pihach, j.c.sackett
CC=
https://codereview.appspot.com/8513043

511. By Richard Harding on 2013-04-08

Support clicking tokens to open charm details.

- Fixes bug in slider that missed cleaning up a timer created.
- Add sample data from the Charmworld0 store api for tests.
- Make sure that we catch charm token clicks
- Refactor the charm details opening to be just the details so we can
retrigger
- Cache model instances so that we don't need to re-fetch the model data in
details views

R=jeff.pihach, j.c.sackett
CC=
https://codereview.appspot.com/8488043

510. By Richard Harding on 2013-04-08

TRIVIAL fix the button CSS in the charm details.

- Update the css styles to fix #1164987

R=
CC=
https://codereview.appspot.com/8492047

509. By Francesco Banconi on 2013-04-08

Handle delta remove events.

Fixed _process_delta so that a remove change coming
from the juju-core delta stream is correctly processed.
The removal requests from pyJuju only contain the id of
the instance to be removed. juju-core sends the whole
entity info instead. This is handled more explicitly
in the _process_delta function.

R=bac, teknico
CC=
https://codereview.appspot.com/8431043

508. By Francesco Banconi on 2013-04-08

Fix Go environment add_relation

Fix the relation key sent to user callbacks in add_relation.
Also fix the API call endpoints parameter.

Changed the services used in relation tests in order to
clarify the difference between relation names, interfaces and
service names.

R=teknico, bac
CC=
https://codereview.appspot.com/8421043