ubuntu-power-tests

Merge lp://staging/~toykeeper/ubuntu-power-tests/apt-update into lp://staging/ubuntu-power-tests

apt-update
Merge into trunk

Proposed by Selene ToyKeeper on 2015-10-19

Status:	Merged
Approved by:	Selene ToyKeeper on 2015-11-10
Approved revision:	87
Merged at revision:	16
Proposed branch:	lp://staging/~toykeeper/ubuntu-power-tests/apt-update
Merge into:	lp://staging/ubuntu-power-tests
Prerequisite:	lp://staging/~toykeeper/ubuntu-power-tests/music-video-lowpower-statistics
Diff against target:	350 lines (+160/-32) 12 files modified debian/changelog (+5/-0) debian/compat (+1/-0) debian/control (+13/-0) debian/copyright (+22/-0) debian/install (+1/-0) debian/rules (+32/-0) debian/source/format (+1/-0) debian/tests/control (+3/-0) debian/tests/placeholder (+2/-0) flash/flash.sh (+14/-0) power.py (+61/-30) test-new-builds.sh (+5/-2)
To merge this branch:	bzr merge lp://staging/~toykeeper/ubuntu-power-tests/apt-update
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot	continuous-integration		Approve on 2015-11-10
Selene ToyKeeper (community)			Needs Resubmitting on 2015-11-10
Max Brustkern (community)		2015-10-19	Approve on 2015-10-21
Review via email: mp+274950@code.staging.launchpad.net

This proposal supersedes a proposal from 2015-10-19.

Commit message

Added --apt-update option, since recent tests completely fail without it.

Description of the change

Added --apt-update option, since recent tests completely fail without it.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-10-19:

FAILED: Continuous integration, rev:84
http://jenkins.qa.ubuntu.com/job/ubuntu-power-tests-ci/44/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-power-tests-vivid-amd64-ci/44/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-power-tests-vivid-armhf-ci/44/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-power-tests-vivid-i386-ci/44/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-power-tests-ci/44/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Max Brustkern (nuclearbob) wrote on 2015-10-20:

Is there a reason this works better than passing in -U to the adt-run commands, or is this just less complicated than adding all that logic to pass the option through things? I know we like to avoid enabling rw when possible, but I can see how this could save time.

Revision history for this message

Selene ToyKeeper (toykeeper) wrote on 2015-10-20:

If we do it at test time, apt-update must run before every test. If we do it at flash time, it only needs to happen once. I find that it can double or triple the per-test time, and is less reliable when performed in a temp directory. It's long enough that we'd also have to extend the timeouts, or every test would fail.

I'm not sure why adt-run no longer works (at all) without an apt-update, but this is the most straightforward fix I've found. Long-term I'd prefer to eliminate its dependencies though, so it wouldn't need to install anything in order to function.

Revision history for this message

Max Brustkern (nuclearbob) wrote on 2015-10-21:

Makes sense to me. Removing dependencies long term is also a good goal.

review: Approve

lp://staging/~toykeeper/ubuntu-power-tests/apt-update updated on 2015-11-10

85. By Selene ToyKeeper on 2015-11-10: Added a very very basic debian/ directory.
Hopefully this will satisfy jenkins.
The actual tests are under adt/debian/ , to avoid problems found
earlier with adt putting way too much junk on the device
(which would actually break the tests).
86. By Selene ToyKeeper on 2015-11-10: Disconnect device after tests finish.
For some reason, this actually results in *lower* power use
(and thus allows the power supply fan to stop between test runs).
87. By Selene ToyKeeper on 2015-11-10: Made wait_for_device() time out after a while, disconnect/reconnect USB,
and try again. This works around USB reliability issues I'm seeing in my
physical test setup.