Code review comment for ~robru/britney/+git/britney2-ubuntu:write-email-cache-often

Revision history for this message
Steve Langasek (vorlon) wrote :

The only thing I see that stands out is that you are writing a log entry each time you call save_state(), and you are now calling save_state() for each email sent. That looks spammy to me. Could you either drop the log message, or write it out only the last time save_state() is called, with britney!=None?

review: Needs Fixing

« Back to merge proposal