Merge ~robru/britney/+git/britney2-ubuntu:write-email-cache-often into ~ubuntu-release/britney/+git/britney2-ubuntu:master
Proposed by
Robert Bruce Park
| Status: | Merged |
|---|---|
| Merged at revision: | 1b4828bfb32f65f2f3e26357d565fafeba611db4 |
| Proposed branch: | ~robru/britney/+git/britney2-ubuntu:write-email-cache-often |
| Merge into: | ~ubuntu-release/britney/+git/britney2-ubuntu:master |
| Diff against target: |
32 lines (+6/-4) 1 file modified
britney2/policies/email.py (+6/-4) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Steve Langasek | Needs Fixing | ||
|
Review via email:
|
|||
Description of the change
Drop asserts that could crash britney, and write sent email cache after every email sent, thus preventing future cases of "britney is spamming mails because it's crashing before it can write it's email cache".
To post a comment you must log in.
Revision history for this message
| Robert Bruce Park (robru) wrote | # |
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The only thing I see that stands out is that you are writing a log entry each time you call save_state(), and you are now calling save_state() for each email sent. That looks spammy to me. Could you either drop the log message, or write it out only the last time save_state() is called, with britney!=None?