Code review comment for lp://staging/~psivaa/britney/announce-generic-testclient

Revision history for this message
Celso Providelo (cprov) wrote :

Psivaa,

We discussed this change in a hangout ...

Basically we should cleanup the configuration setup (remove DEBUG, ARCHES and FETCH and replace your 'products' by 'required_test', everything prefixed with TESTCLIENT_) and the TestClient logic (cache per series, plain dictionary keyed by (sourcename, version), json.{dump, load}, replace needs_announce with 'if (name, version) in cache.keys()', re-use connection & SimpleQueue to announce everything in that batch).

Let's give it another round of review before staging the changes.

review: Needs Fixing

« Back to merge proposal