Merge lp://staging/~psivaa/britney/announce-generic-testclient into lp://staging/~canonical-ci-engineering/britney/queued-announce-and-collect
Proposed by
Para Siva
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~psivaa/britney/announce-generic-testclient |
| Merge into: | lp://staging/~canonical-ci-engineering/britney/queued-announce-and-collect |
| Diff against target: |
211 lines (+174/-0) 3 files modified
britney.conf (+4/-0) britney.py (+52/-0) testclient.py (+118/-0) |
| To merge this branch: | bzr merge lp://staging/~psivaa/britney/announce-generic-testclient |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Celso Providelo (community) | Needs Fixing | ||
|
Review via email:
|
|||
Commit message
Functionality to post a package details to pm.candidates queue
Description of the change
Functionality to post a package details to pm.candidates queue. Still to do is to update the excuses file with the entries. This will be part of another MP.
To post a comment you must log in.
Revision history for this message
| Para Siva (psivaa) wrote | # |
Revision history for this message
| Celso Providelo (cprov) wrote | # |
Unmerged revisions
- 443. By Para Siva
-
Replace source with candidate name
- 442. By Para Siva
-
Remove entry from excuses
- 441. By Para Siva
-
Remove an entry from the cache if new version comes up
- 440. By Para Siva
-
After review meeting first pass
- 439. By Para Siva
-
Move caching decision to testclient
- 438. By Para Siva
-
pep8 and pyflakes
- 437. By Para Siva
-
A couple of tests
- 436. By Para Siva
-
Second pass with dup package entries
- 435. By Para Siva
-
Announce source package initial commit
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Psivaa,
We discussed this change in a hangout ...
Basically we should cleanup the configuration setup (remove DEBUG, ARCHES and FETCH and replace your 'products' by 'required_test', everything prefixed with TESTCLIENT_) and the TestClient logic (cache per series, plain dictionary keyed by (sourcename, version), json.{dump, load}, replace needs_announce with 'if (name, version) in cache.keys()', re-use connection & SimpleQueue to announce everything in that batch).
Let's give it another round of review before staging the changes.