Description:
Hook up cancel buttons in the inspector
This branch simply hooks up the cancel buttons, which thanks to
groundwork from Ben that I worked on in previous branches, is a one
liner for each button.
For QA, on config and constraints page, make an edit, and then press
cancel. make an edit and trigger a conflict, and then press cancel.
Make an edit and trigger a conflict and then begin to choose options,
and then press cancel.
True confessions: I only tried out one of those in automated tests.
I'll try it out now myself. :-)
Affected files (+211, -1 lines):
A [revision details]
M app/views/environment.js
M app/views/inspector.js
M test/test_inspector_constraints.js
M test/test_inspector_settings.js
Reviewers: mp+185593_ code.launchpad. net,
Message:
Please take a look.
Description:
Hook up cancel buttons in the inspector
This branch simply hooks up the cancel buttons, which thanks to
groundwork from Ben that I worked on in previous branches, is a one
liner for each button.
For QA, on config and constraints page, make an edit, and then press
cancel. make an edit and trigger a conflict, and then press cancel.
Make an edit and trigger a conflict and then begin to choose options,
and then press cancel.
True confessions: I only tried out one of those in automated tests.
I'll try it out now myself. :-)
https:/ /code.launchpad .net/~gary/ juju-gui/ enableInspector Cancel/ +merge/ 185593
(do not edit description out of merge proposal)
Please review this at https:/ /codereview. appspot. com/13677044/
Affected files (+211, -1 lines): environment. js inspector. js inspector_ constraints. js inspector_ settings. js
A [revision details]
M app/views/
M app/views/
M test/test_
M test/test_