Merge lp://staging/~gary/juju-gui/enableInspectorCancel into lp://staging/juju-gui/experimental

Reviewers: mp+185593_code.launchpad.net,

Message:
Please take a look.

Description:
Hook up cancel buttons in the inspector

This branch simply hooks up the cancel buttons, which thanks to
groundwork from Ben that I worked on in previous branches, is a one
liner for each button.

For QA, on config and constraints page, make an edit, and then press
cancel. make an edit and trigger a conflict, and then press cancel.
Make an edit and trigger a conflict and then begin to choose options,
and then press cancel.

True confessions: I only tried out one of those in automated tests.
I'll try it out now myself. :-)

https://code.launchpad.net/~gary/juju-gui/enableInspectorCancel/+merge/185593

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/13677044/

Affected files (+211, -1 lines):
   A [revision details]
   M app/views/environment.js
   M app/views/inspector.js
   M test/test_inspector_constraints.js
   M test/test_inspector_settings.js

LGTM
QA Good in IE/Chrome

Thanks for this.

https://codereview.appspot.com/13677044/diff/1/app/views/inspector.js
File app/views/inspector.js (right):

https://codereview.appspot.com/13677044/diff/1/app/views/inspector.js#newcode837
app/views/inspector.js:837:
this.viewletManager.bindingEngine.resetDOMToModel('config');
This is how I hoped these would read, sorry it was so much work to make
that actually true.

https://codereview.appspot.com/13677044/

*** Submitted:

Hook up cancel buttons in the inspector

This branch simply hooks up the cancel buttons, which thanks to
groundwork from Ben that I worked on in previous branches, is a one
liner for each button.

R=benjamin.saller
CC=
https://codereview.appspot.com/13677044

https://codereview.appspot.com/13677044/

On 2013/09/13 20:37:20, benjamin.saller wrote:
> LGTM
> QA Good in IE/Chrome

> Thanks for this.

> https://codereview.appspot.com/13677044/diff/1/app/views/inspector.js
> File app/views/inspector.js (right):

https://codereview.appspot.com/13677044/diff/1/app/views/inspector.js#newcode837
> app/views/inspector.js:837:
> this.viewletManager.bindingEngine.resetDOMToModel('config');
> This is how I hoped these would read, sorry it was so much work to
make that
> actually true.

Thank you, Ben!

https://codereview.appspot.com/13677044/