lp://staging/~gary/juju-gui/enableInspectorCancel

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/juju-gui/experimental at revision 1042

Juju GUI Hackers: Pending requested 2013-09-13

Diff: 275 lines (+209/-1)

4 files modified

app/views/environment.js (+4/-1)
app/views/inspector.js (+22/-0)
test/test_inspector_constraints.js (+80/-0)
test/test_inspector_settings.js (+103/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

1040. By Gary Poster on 2013-09-13

hook up inspector cancel buttons

1039. By Gary Poster on 2013-09-13

Eliminate unnecessary conflicts

Fixes the following issues:
 * If you change one model parent.child value (e.g. constraints.arch) in the inspector and then set a model parent.child value (e.g., constaints.cpu-cores) in the db, you will get an unnecessary conflict on the arch.
 * resetDOMToModel could not clear conflicts.

I also added a lot of comments, and a couple of tests for pre-existing functionality that I broke during my refactoring.

R=rharding, benjamin.saller
CC=
https://codereview.appspot.com/13340047

1038. By Gary Poster on 2013-09-13

Fix lint and tests

Tweak code so tests pass.

R=
CC=
https://codereview.appspot.com/13250048

1037. By Brad Crittenden on 2013-09-12

[r=rick_h] Add GA_key as a config variable. Remove useAnalytics. Turn off GA by setting the key to blank.

1036. By Benji York on 2013-09-12

More/tweaked tests for the charmworld v2 API

The code was also tweaked in directions suggested by the new/refactored tests.

1035. By Richard Harding on 2013-09-12

Update conflict ux per updated design.

- design images: https://www.dropbox.com/sh/kuzzisylxrozkbe/iUR0SPSIXL#/
- Update checkboxes to be a slider widget, two levels tall
- Display the True/False value and keep it in sync
- Update the Expose/Use default setting checkboxes to match the updated design
- Update conflict settings for the conflict-pending with the new smaller image

R=jeff.pihach, bac
CC=
https://codereview.appspot.com/13516044

1034. By Huw Wilkins on 2013-09-12

Style the relations tab

This branch styles the relations tab as per design.

It also adds icons for the active state of the inspector tabs.
(Landing for Huw)

R=jeff.pihach
CC=
https://codereview.appspot.com/13333053

1033. By Jeff Pihach on 2013-09-11

Adds relation details viewlet to inspector

This branch adds the relation details viewlet to the inspector
and databinds the values to the relation interactions.

As with units we now keep a copy of the relations data on the
service and keep that up to date during the users interactions
and deltas to allow for easy data binding for the viewlet.

We no longer rely on the relation_error attribute and instead
have aggregateRelations and aggregateRelationError attributes.

R=benjamin.saller, rharding
CC=
https://codereview.appspot.com/13373050

1032. By Richard Harding on 2013-09-11

Show 5 downgrades, then expand link

Per UX, this branch shows 5 downgrades with an expand link in the case of not
having an upgrade available, rather than all downgrades at once.

R=
CC=
https://codereview.appspot.com/13667043

1031. By Gary Poster on 2013-09-11

fix successive conflict UX calls

if you set a model value and then set a new one, the newest one will be lost. This branch fixes that problem, and adds a test for simpler conflict UX.

R=rharding
CC=
https://codereview.appspot.com/13663043