Code review comment for lp://staging/~zsombi/ubuntu-ui-toolkit/40-visualize-options

Revision history for this message
Zsombor Egri (zsombi) wrote :

> I am testing with this test program
> https://code.launchpad.net/~tpeeters/+junk/lists and I see the following
> potential UX problems:
> - When I swipe left/right, and then release the mouse button, the list item
> stays exactly where it was, see https://www.dropbox.com/s/iinpzauwtm7hhsn/Scre
> enshot%202014-11-24%2015.23.47.png?dl=0 I think it should snap in or out, or
> to the nearest border between actions

I think we should go thru the MRs because you keep posting comments that will be solved in later MRs. snap comes in 55. It should either snap in or out, there's no snap to action borders, Mark disliked that.

> - When I press an action, there is no visible highlight on the action

No visible highlight was requested or specified by design.

> - When I press an action, the list item itself gets highlighted. But when I
> release the button, the highlight stays.

Hmm, that's a bug. And I think it got fixed in a later MR, but must check it.

« Back to merge proposal