Merge lp://staging/~zsombi/ubuntu-ui-toolkit/40-visualize-options into lp://staging/~zsombi/ubuntu-ui-toolkit/listitem-master

ListItem's data and child properties had to be renamed as findChild()/findInvisibleChild() won't find the panel item anymore.

I am testing with this test program https://code.launchpad.net/~tpeeters/+junk/lists and I see the following potential UX problems:
- When I swipe left/right, and then release the mouse button, the list item stays exactly where it was, see https://www.dropbox.com/s/iinpzauwtm7hhsn/Screenshot%202014-11-24%2015.23.47.png?dl=0 I think it should snap in or out, or to the nearest border between actions
- When I press an action, there is no visible highlight on the action
- When I press an action, the list item itself gets highlighted. But when I release the button, the highlight stays.

I like to have some more flexibility in coloring the background of the panel. Currently the left one is always red, the right one white.

I would like to have the possibility to easily change these standard colors (left: green, right: yellow, or example). And maybe even have the possibility to change the background color per action in each of the panels. That last possibility is still a point of discussion.

I like to have a delete action that deletes the list item that the action was added to, but for leadingActions, I use a reference to a common set of actions that we have for each list item. So I would need the Action.trigger() function to be called with the index of the list item in order to know which one needs to be deleted. Or do you know a better solution?

This is not only the case for deleting of list items. Each action (edit, move, reply e-mail, todo item done, etc) needs to know to which list item it applies.

Hi Tim,

- When you swipe left/right, and then release, the list item should snap in and reveal *all the trailing or leading actions*
- When you press an action, there *should be* a visible highlight on the action (tap state)
- When you press an action, the list item should not be highlighted.
- I would recommend to give the possibility to change the background colour per action in each of the panels, but provide a default colour

> I am testing with this test program
> https://code.launchpad.net/~tpeeters/+junk/lists and I see the following
> potential UX problems:
> - When I swipe left/right, and then release the mouse button, the list item
> stays exactly where it was, see https://www.dropbox.com/s/iinpzauwtm7hhsn/Scre
> enshot%202014-11-24%2015.23.47.png?dl=0 I think it should snap in or out, or
> to the nearest border between actions

I think we should go thru the MRs because you keep posting comments that will be solved in later MRs. snap comes in 55. It should either snap in or out, there's no snap to action borders, Mark disliked that.

> - When I press an action, there is no visible highlight on the action

No visible highlight was requested or specified by design.

> - When I press an action, the list item itself gets highlighted. But when I
> release the button, the highlight stays.

Hmm, that's a bug. And I think it got fixed in a later MR, but must check it.

> I like to have some more flexibility in coloring the background of the panel.
> Currently the left one is always red, the right one white.

As discussed, we can add these properties to ListItemActions, but that will always be applied to these objects. The panel delegates are linked to ListItems, so in that sense these properties would rather be welcomed there than ListItemActions. We can discuss this later, and perhaps have it in a later MR.
>
> I would like to have the possibility to easily change these standard colors
> (left: green, right: yellow, or example). And maybe even have the possibility
> to change the background color per action in each of the panels. That last
> possibility is still a point of discussion.

Per action can be driven thru the ListItemActions.delegate (comes in MR# 50). Otherwise these color props must be added to action, which shouldn't be the case. OTOH, custom panel theme can be used any time for this.

> I like to have a delete action that deletes the list item that the action was
> added to, but for leadingActions, I use a reference to a common set of actions
> that we have for each list item. So I would need the Action.trigger() function
> to be called with the index of the list item in order to know which one needs
> to be deleted. Or do you know a better solution?

It is done like that. The index is provided in MR #60.

>
> This is not only the case for deleting of list items. Each action (edit, move,
> reply e-mail, todo item done, etc) needs to know to which list item it
> applies.

Watch for MR #60 :)

> Hi Tim,
>
> - When you swipe left/right, and then release, the list item should snap in
> and reveal *all the trailing or leading actions*

MR #55.

> - When you press an action, there *should be* a visible highlight on the
> action (tap state)

This is the first time I hear this. It would be nice to know what they mean about that.

> - When you press an action, the list item should not be highlighted.

If it done so, this is because there's no MouseArea yet in the ListItemPanel to handle the press events. When that is there, the highlight will also disappear. So the previous founding you had was because of this.

> - I would recommend to give the possibility to change the background colour
> per action in each of the panels, but provide a default colour

That requires color properties to be given in Actions. I do not think this is nice way to do things. OTOH, ListItemActions.delegate can be used for this, but then delegates must handle the action visualization, just like done in MR %50.

Pressed action highlight added; Highlight when actions are pressed fixed.

works good now, including highlights :)