Merge ~woutervb/charm-prometheus-libvirt-exporter:bug/1873371 into charm-prometheus-libvirt-exporter:master
Proposed by
Wouter van Bommel
Status: | Rejected |
---|---|
Rejected by: | Xav Paice |
Proposed branch: | ~woutervb/charm-prometheus-libvirt-exporter:bug/1873371 |
Merge into: | charm-prometheus-libvirt-exporter:master |
Diff against target: |
219 lines (+128/-3) 10 files modified
.gitignore (+4/-0) Makefile (+19/-0) config.yaml (+14/-0) dev/null (+0/-1) layer.yaml (+5/-1) metadata.yaml (+2/-0) reactive/libvirt_exporter.py (+31/-1) tests/unit/test_libvirt_exporter.py (+28/-0) tests/unit/test_requirements.txt (+4/-0) tox.ini (+21/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Xav Paice (community) | Disapprove | ||
Alvaro Uria (community) | Needs Fixing | ||
Review via email: mp+382466@code.staging.launchpad.net |
To post a comment you must log in.
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
LGTM, one comment but possibly for a future change when adding functional testing.