Prometheus libvirt exporter charm

Code review comment for ~woutervb/charm-prometheus-libvirt-exporter:bug/1873371

  1. Git
  2. lp:~woutervb/charm-prometheus-libvirt-exporter
  3. bug/1873371
  4. Merge into master
Revision history for this message
Alvaro Uria (aluria) wrote :

Hey Wouter,

I think this change is superseded by [1]. Dave's MP adds nrpe support and functional tests. I've asked Dave to move the functional tests into ./tests/functional and possibly remove the unit tests details because there are no unit tests. He is not on Dev rotation but if you have time, could you take on his work and create a single MP?

Thank you. I'll mark this message as "Needs fixing" and the MP as "WIP" to unlist it from the pending reviews.

1. https://code.launchpad.net/~dmzoneill/charm-prometheus-libvirt-exporter/+git/charm-prometheus-libvirt-exporter/+merge/380729

review: Needs Fixing

« Back to merge proposal