Code review comment for lp://staging/~vrruiz/qakit/i18ncheck

Revision history for this message
Allan LeSage (allanlesage) wrote :

Some fixes suggested below, a lot of style stuff--note that I've tested this working, will be fine but let's do one more round. Meanwhile some discussion points:

* IMO the command-line output needs more information, not sure what I'm looking at.
* Give a little more context in your README.
* Let's get this to pass flake8 pls :) .
* We can make this distributable, i.e. via deb-packaging--would that help to get it onto a device, e.g.?

Lastly I'm making a branch with a test to merge into this just for kicks--would you do a merge of trunk please? (You inspired me to fix our tests ;) .) And then merge that test branch if you wish.

review: Needs Fixing

« Back to merge proposal