Merge lp://staging/~vrruiz/qakit/i18ncheck into lp://staging/qakit
Proposed by
Víctor R. Ruiz
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~vrruiz/qakit/i18ncheck |
| Merge into: | lp://staging/qakit |
| Diff against target: |
617 lines (+581/-0) 7 files modified
qakit/i18ncheck/README (+14/-0) qakit/i18ncheck/TranslationChecker.py (+184/-0) qakit/i18ncheck/check-i18n-click.sh (+76/-0) qakit/i18ncheck/check-i18n-deb.sh (+129/-0) qakit/i18ncheck/checkpomo.py (+31/-0) qakit/i18ncheck/i18ncheck.py (+58/-0) qakit/i18ncheck/tests/test_filter_strings.py (+89/-0) |
| To merge this branch: | bzr merge lp://staging/~vrruiz/qakit/i18ncheck |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Allan LeSage (community) | Needs Fixing | ||
|
Review via email:
|
|||
Commit message
Translation checker.
Description of the change
Translation checker.
To post a comment you must log in.
Revision history for this message
| Víctor R. Ruiz (vrruiz) wrote | # |
Unmerged revisions
- 23. By Víctor R. Ruiz
-
Re-org.
- 22. By Víctor R. Ruiz
-
Fixes
- 21. By Víctor R. Ruiz
-
Fix checking multiple directories
- 20. By Víctor R. Ruiz
-
Fix flake8
- 19. By Víctor R. Ruiz
-
Better README
- 18. By Víctor R. Ruiz
-
Parse arguments and display command line help
- 17. By Víctor R. Ruiz
-
Traverse multiple directories to grab click packages
- 16. By Víctor R. Ruiz
-
Merge tests
- 15. By Víctor R. Ruiz
-
Argument support for locale check
- 14. By Víctor R. Ruiz
-
Check translations for a particular locale
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Some fixes suggested below, a lot of style stuff--note that I've tested this working, will be fine but let's do one more round. Meanwhile some discussion points:
* IMO the command-line output needs more information, not sure what I'm looking at.
* Give a little more context in your README.
* Let's get this to pass flake8 pls :) .
* We can make this distributable, i.e. via deb-packaging-
Lastly I'm making a branch with a test to merge into this just for kicks--would you do a merge of trunk please? (You inspired me to fix our tests ;) .) And then merge that test branch if you wish.