Code review comment for lp://staging/~vila/ols-store-tests/redirection-failures

Revision history for this message
Ricardo Kirkner (ricardokirkner) wrote :

<pindonga> vila, mhh
<pindonga> I mean... that means that the current staging server and tests only work inside the datacenter?
<pindonga> afaik .internal is not resolvable outside the internal network
<pindonga> not even sure if via vpn
<vila> pindonga: hmm, no, the tests work from outside
<vila> pindonga: what doesn't work (from inside the vpn) is to attempt to use .internal because it's self-signed so ssl barfs
<pindonga> ah, it works bc it only shows you the url in the data
<pindonga> it doesn't try to actually go to that url
<pindonga> that would fail
<vila> pindonga: the tests (as they are written right now), requires that the url in the response is myapps. yeah that
<vila> yes
<pindonga> do you know why we redirect to an internal url?
<pindonga> is it bc we don't yet have a dns name defined?
<vila> because the domain is still unknown
<vila> yes
<pindonga> k
<pindonga> I guess it's ok for now
<pindonga> though I'm not that satisfied (with the overall redirect approach) I'll +1 this mp
<vila> so the tests will fail again once we have that domain, but I prefer that over... yeah

review: Approve

« Back to merge proposal