Merge lp://staging/~vila/ols-store-tests/redirection-failures into lp://staging/~ubuntuone-pqm-team/ols-store-tests/store-acceptance-tests
Proposed by
Vincent Ladeuil
Status: | Merged |
---|---|
Approved by: | Vincent Ladeuil |
Approved revision: | 42 |
Merged at revision: | 42 |
Proposed branch: | lp://staging/~vila/ols-store-tests/redirection-failures |
Merge into: | lp://staging/~ubuntuone-pqm-team/ols-store-tests/store-acceptance-tests |
Diff against target: |
35 lines (+12/-2) 1 file modified
tests/api/snap/test_register_name.py (+12/-2) |
To merge this branch: | bzr merge lp://staging/~vila/ols-store-tests/redirection-failures |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ricardo Kirkner (community) | Approve | ||
Review via email:
|
Commit message
Fix scasnap redirection related failures.
Description of the change
https:/
In the long run, once it gets a proper domain, this won't be an issue.
Since these tests are focused on snap-v2, it seems more appropriate to target the new domain rather than the old and fixing redirection issues (dedicated tests would be more appropriate if we want that).
This proposal is therefore a short term solution to get the job back to green.
To post a comment you must log in.
<pindonga> vila, mhh
<pindonga> I mean... that means that the current staging server and tests only work inside the datacenter?
<pindonga> afaik .internal is not resolvable outside the internal network
<pindonga> not even sure if via vpn
<vila> pindonga: hmm, no, the tests work from outside
<vila> pindonga: what doesn't work (from inside the vpn) is to attempt to use .internal because it's self-signed so ssl barfs
<pindonga> ah, it works bc it only shows you the url in the data
<pindonga> it doesn't try to actually go to that url
<pindonga> that would fail
<vila> pindonga: the tests (as they are written right now), requires that the url in the response is myapps. yeah that
<vila> yes
<pindonga> do you know why we redirect to an internal url?
<pindonga> is it bc we don't yet have a dns name defined?
<vila> because the domain is still unknown
<vila> yes
<pindonga> k
<pindonga> I guess it's ok for now
<pindonga> though I'm not that satisfied (with the overall redirect approach) I'll +1 this mp
<vila> so the tests will fail again once we have that domain, but I prefer that over... yeah