Code review comment for lp://staging/~vila/bzr-loom/595584-lazy-load-remote

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Vincent Ladeuil wrote:
> Vincent Ladeuil has proposed merging lp:~vila/bzr-loom/595584-lazy-load-remote into lp:bzr-loom with lp:~vila/bzr-loom/595563-switch-directory as a prerequisite.
>
> Requested reviews:
> Loom Developers (bzr-loom-devs)
> Related bugs:
> #595584 test failure: AssertionError: command ['st'] loaded forbidden modules ['bzrlib.remote', 'bzrlib.smart']
> https://bugs.launchpad.net/bugs/595584
>
>
> Fix the test failure. I'm not super convinced that's the right approach but I was blocked and this works.
>

This seems correct, but unrelated:
@@ -743,11 +744,11 @@
             branch_transport, 'lock', bzrlib.lockdir.LockDir)
         control_files.lock_write()
         try:
- - for name, stream in files:
- - branch_transport.put_file(name, stream)
+ for file_name, stream in files:
+ branch_transport.put_file(file_name, stream)
         finally:
             control_files.unlock()
- - return self.open(a_bzrdir, _found=True, )
+ return self.open(a_bzrdir, _found=True, name=name)

Otherwise, why not use lazy import up at the top, rather than multiple
local imports later?

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkwaWvMACgkQJdeBCYSNAAPMKwCfeCk8Ba/aGtGt4hLgd6NEgFbl
bmcAoKIYOHLScNXfpBwgI+XmYfAweR5e
=pdaK
-----END PGP SIGNATURE-----