Merge lp://staging/~vila/bzr-loom/595584-lazy-load-remote into lp://staging/bzr-loom
Proposed by
Vincent Ladeuil
Status: | Rejected |
---|---|
Rejected by: | Robert Collins |
Proposed branch: | lp://staging/~vila/bzr-loom/595584-lazy-load-remote |
Merge into: | lp://staging/bzr-loom |
Prerequisite: | lp://staging/~vila/bzr-loom/595563-switch-directory |
Diff against target: |
56 lines (+8/-4) 2 files modified
NEWS (+2/-0) branch.py (+6/-4) |
To merge this branch: | bzr merge lp://staging/~vila/bzr-loom/595584-lazy-load-remote |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robert Collins (community) | Needs Fixing | ||
Review via email:
|
Description of the change
Fix the test failure. I'm not super convinced that's the right approach but I was blocked and this works.
To post a comment you must log in.
Unmerged revisions
- 116. By Vincent Ladeuil
-
Fix bzr test_import_tariff failure
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Vincent Ladeuil wrote: /bugs.launchpad .net/bugs/ 595584
> Vincent Ladeuil has proposed merging lp:~vila/bzr-loom/595584-lazy-load-remote into lp:bzr-loom with lp:~vila/bzr-loom/595563-switch-directory as a prerequisite.
>
> Requested reviews:
> Loom Developers (bzr-loom-devs)
> Related bugs:
> #595584 test failure: AssertionError: command ['st'] loaded forbidden modules ['bzrlib.remote', 'bzrlib.smart']
> https:/
>
>
> Fix the test failure. I'm not super convinced that's the right approach but I was blocked and this works.
>
This seems correct, but unrelated:
branch_ transport, 'lock', bzrlib. lockdir. LockDir)
control_ files.lock_ write() transport. put_file( name, stream) transport. put_file( file_name, stream)
control_ files.unlock( )
@@ -743,11 +744,11 @@
try:
- - for name, stream in files:
- - branch_
+ for file_name, stream in files:
+ branch_
finally:
- - return self.open(a_bzrdir, _found=True, )
+ return self.open(a_bzrdir, _found=True, name=name)
Otherwise, why not use lazy import up at the top, rather than multiple
local imports later?
John
=:->
-----BEGIN PGP SIGNATURE----- enigmail. mozdev. org/
aWvMACgkQJdeBCY SNAAPMKwCfeCk8B a/aGtGt4hLgd6NE gFbl fpBwgI+ XmYfAweR5e
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAkw
bmcAoKIYOHLScNX
=pdaK
-----END PGP SIGNATURE-----