QtMir

Merge lp://staging/~unity-team/qtmir/multimonitorNext into lp://staging/qtmir

  1. multimonitorNext
  2. Merge into trunk
Proposed by Michał Sawicz
Status: Merged
Approved by: Michał Sawicz
Approved revision: 390
Merged at revision: 391
Proposed branch: lp://staging/~unity-team/qtmir/multimonitorNext
Merge into: lp://staging/qtmir
Prerequisite: lp://staging/~unity-team/qtmir/surviveEmptyTexture
Diff against target: 345 lines (+77/-84)
11 files modified
src/common/debughelpers.cpp (+30/-1)
src/common/debughelpers.h (+1/-0)
src/platforms/mirserver/mirserver.cpp (+7/-1)
src/platforms/mirserver/mirserverintegration.cpp (+3/-11)
src/platforms/mirserver/qtcompositor.cpp (+13/-0)
src/platforms/mirserver/qtcompositor.h (+12/-0)
src/platforms/mirserver/qteventfeeder.cpp (+6/-2)
src/platforms/mirserver/screencontroller.cpp (+5/-52)
src/platforms/mirserver/screencontroller.h (+0/-1)
src/platforms/mirserver/screenwindow.cpp (+0/-4)
tests/mirserver/ScreenController/screencontroller_test.cpp (+0/-12)
To merge this branch: bzr merge lp://staging/~unity-team/qtmir/multimonitorNext
Reviewer Review Type Date Requested Status
Michał Sawicz Approve
Gerry Boland Pending
PS Jenkins bot continuous-integration Pending
Review via email: mp+274516@code.staging.launchpad.net

This proposal supersedes a proposal from 2015-10-02.

Commit message

Improve multimonitor support

* Removed magic:
 - Don't automagically select the screen where a window will be show.
   Let shell decide.
 - Don't automagically focus a window. Let shell handle it.

* Let shell know when a screen is about to be removed so that it has
  the opportunity to move or destroy a window in it before it's too late.
  - Added QGuiApplication::onScreenAboutToBeRemoved

* Added logging to key events

Description of the change

Known issues:
- Input events come at very irregular intervals (if at all) when an external monitor is connected to a phone or tablet. Works fine on a laptop connected to an external monitor.

* Are there any related MPs required for this MP to build/function as expected? Please list.
No, but to see any difference you should use this untiy8 branch:
https://code.launchpad.net/~unity-team/unity8/externalMonitor/+merge/273829

* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:387
http://jenkins.qa.ubuntu.com/job/qtmir-ci/478/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-amd64-ci/174/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-armhf-ci/174/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-i386-ci/56/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-amd64-ci/211/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/211/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-i386-ci/56/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/478/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:388
http://jenkins.qa.ubuntu.com/job/qtmir-ci/480/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-amd64-ci/176/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-armhf-ci/176/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-i386-ci/58/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-amd64-ci/213/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/213/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-i386-ci/58/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/480/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Gerry Boland (gerboland) wrote : Posted in a previous version of this proposal

QGuiApplication::onScreenAboutToBeRemoved
How necessary is this? The QWindow has been hidden, so it has released its GL context and should be safe to hold onto until you get the screenRemoved signal.

review: Needs Information
Revision history for this message
Daniel d'Andrada (dandrader) wrote : Posted in a previous version of this proposal

On 06/10/2015 19:16, Gerry Boland wrote:
> Review: Needs Information
>
> QGuiApplication::onScreenAboutToBeRemoved
> How necessary is this? The QWindow has been hidden, so it has released its GL context and should be safe to hold onto until you get the screenRemoved signal.
 Experience tells otherwise (it would crash).

Revision history for this message
Gerry Boland (gerboland) wrote : Posted in a previous version of this proposal

> On 06/10/2015 19:16, Gerry Boland wrote:
> > Review: Needs Information
> >
> > QGuiApplication::onScreenAboutToBeRemoved
> > How necessary is this? The QWindow has been hidden, so it has released its
> GL context and should be safe to hold onto until you get the screenRemoved
> signal.
> Experience tells otherwise (it would crash).

It's not supposed to! :) But this it technically more correct, so am ok with it.

Revision history for this message
Gerry Boland (gerboland) : Posted in a previous version of this proposal
review: Approve
lp://staging/~unity-team/qtmir/multimonitorNext updated
390. By Michał Sawicz

Merge lp:~unity-team/qtmir/surviveEmptyTexture

Revision history for this message
Michał Sawicz (saviq) wrote :

Approving as per prerequisite

review: Approve
Revision history for this message
Michał Sawicz (saviq) wrote :

> Approving as per prerequisite

s/prerequisite/superseded/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches