QtMir

Merge lp://staging/~unity-team/qtmir/liveCaption into lp://staging/qtmir

  1. liveCaption
  2. Merge into trunk
Proposed by Michał Sawicz
Status: Merged
Approved by: Daniel d'Andrada
Approved revision: 391
Merged at revision: 393
Proposed branch: lp://staging/~unity-team/qtmir/liveCaption
Merge into: lp://staging/qtmir
Prerequisite: lp://staging/~alan-griffiths/qtmir/small-refactoring-of-MirWindowManager
Diff against target: 127 lines (+23/-10)
6 files modified
CMakeLists.txt (+1/-1)
debian/control (+1/-1)
src/modules/Unity/Application/mirsurface.cpp (+1/-1)
src/platforms/mirserver/mirwindowmanager.cpp (+12/-5)
src/platforms/mirserver/surfaceobserver.cpp (+5/-0)
src/platforms/mirserver/surfaceobserver.h (+3/-2)
To merge this branch: bzr merge lp://staging/~unity-team/qtmir/liveCaption
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Daniel d'Andrada (community) Approve
Gerry Boland Pending
Review via email: mp+273071@code.staging.launchpad.net

Commit message

React to surface modifications (window caption)

Description of the change

React to surface modifications (window caption)

Cf. https://bugs.launchpad.net/ubuntu/+source/unity-api/+bug/1497092

* Are there any related MPs required for this MP to build/function as expected? Please list.

Yes, build depends on this unity-api MP: https://code.launchpad.net/~lukas-kde/unity-api/liveCaption/+merge/272769
Functionality-wise, also depends on qtubuntu MP: https://code.launchpad.net/~lukas-kde/qtubuntu/liveCaption/+merge/272756

To actually see the results you also need: https://code.launchpad.net/~lukas-kde/unity8/liveCaption/+merge/272760

* Did you perform an exploratory manual test run of your code change and any related functionality?

Yes

* Did you make sure that your branch does not contain spurious tags?

Yes

* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

Yes

* If you changed the UI, has there been a design review?

N/A

To post a comment you must log in.
Revision history for this message
Daniel d'Andrada (dandrader) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:391
http://jenkins.qa.ubuntu.com/job/qtmir-ci/470/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-amd64-ci/166/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-armhf-ci/166/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-i386-ci/48/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-amd64-ci/203/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/203/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-i386-ci/48/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/470/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches