Juju Charms Collection
ntp package

Code review comment for lp://staging/~tribaal/charms/trusty/ntp/use-charm-helpers-templating

  1. Trusty Tahr (14.04)
  2. use-charm-helpers-templating
  3. Merge into trunk
Revision history for this message
Cory Johns (johnsca) wrote :

Chris,

This change looks good. I have one question about the in-memory apt_pkg change. Since hooks won't ever run concurrently, is there really a need for that change? That said, it won't hurt, but if there really is a concern about collisions, should be it merged upstream?

Regardless, this MP gets my +1.

review: Approve

« Back to merge proposal