Merge lp://staging/~tribaal/charms/trusty/ntp/use-charm-helpers-templating into lp://staging/charms/trusty/ntp
Proposed by
Chris Glass
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 16 | ||||
| Proposed branch: | lp://staging/~tribaal/charms/trusty/ntp/use-charm-helpers-templating | ||||
| Merge into: | lp://staging/charms/trusty/ntp | ||||
| Diff against target: |
78 lines (+9/-26) 4 files modified
charm-helpers-sync.yaml (+1/-0) hooks/charmhelpers/core/host.py (+4/-0) hooks/ntp_hooks.py (+4/-5) hooks/utils.py (+0/-21) |
||||
| To merge this branch: | bzr merge lp://staging/~tribaal/charms/trusty/ntp/use-charm-helpers-templating | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Charles Butler (community) | Approve | ||
| Cory Johns (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
This branch removes the copy/pasted jinja templating code and makes the charm use the charmhelpers version instead.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Chris,
This change looks good. I have one question about the in-memory apt_pkg change. Since hooks won't ever run concurrently, is there really a need for that change? That said, it won't hurt, but if there really is a concern about collisions, should be it merged upstream?
Regardless, this MP gets my +1.