Code review comment for lp://staging/~thumper/launchpad/bzr-transport-branch-id-access

Revision history for this message
Graham Binns (gmb) wrote :

This is good to land with a couple of additions:

124 + def test_translatePath_branch_id_alias_private_branch(self):

and

135 + def test_translatePath_branch_id_alias_private_branch_no_access(self):

Both need docstrings or explanatory comments so that I don't have to read them to understand what they test.

review: Approve (code)

« Back to merge proposal