Launchpad itself

Merge lp://staging/~thumper/launchpad/bzr-transport-branch-id-access into lp://staging/launchpad

  1. bzr-transport-branch-id-access
  2. Merge into devel
Proposed by Tim Penhey
Status: Merged
Merged at revision: 12758
Proposed branch: lp://staging/~thumper/launchpad/bzr-transport-branch-id-access
Merge into: lp://staging/launchpad
Prerequisite: lp://staging/~thumper/launchpad/anon-http-branch-id-access
Diff against target: 213 lines (+120/-9)
3 files modified
lib/lp/code/xmlrpc/codehosting.py (+30/-3)
lib/lp/code/xmlrpc/tests/test_codehosting.py (+58/-0)
lib/lp/codehosting/inmemory.py (+32/-6)
To merge this branch: bzr merge lp://staging/~thumper/launchpad/bzr-transport-branch-id-access
Reviewer Review Type Date Requested Status
Graham Binns (community) code Approve
Review via email: mp+56288@code.staging.launchpad.net

Description of the change

This branch provides support for the +branch-id alias over
the smartserver and sftp through our VFS.

All access to branches using the +branch-id alias are read
only.

To post a comment you must log in.
Revision history for this message
Graham Binns (gmb) wrote :

This is good to land with a couple of additions:

124 + def test_translatePath_branch_id_alias_private_branch(self):

and

135 + def test_translatePath_branch_id_alias_private_branch_no_access(self):

Both need docstrings or explanatory comments so that I don't have to read them to understand what they test.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.