Code review comment for lp://staging/~termie/bzr-fastimport/marks_normalization
Revision history for this message
| Jelmer Vernooij (jelmer) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
4b6b663
demo site
(Get the code!)
On Mon, Jan 31, 2011 at 08:39:52AM -0000, Martin Pool wrote:
> I ran the tests in your branch and they all passed. So we haven't gone backwards. If it's possible to easily add some tests for what was broken, that would be nice. Otherwise, let's just merge it.
+1
It'd be nice to have a single function that can resolve marks (and
just does .lstrip(":") for now, but perhaps more later).
It also seems reasonable enough to land as-is, though.
Cheers,
Jelmer