Merge lp://staging/~termie/bzr-fastimport/marks_normalization into lp://staging/bzr-fastimport
Proposed by
termie
Status: | Merged |
---|---|
Merged at revision: | 305 |
Proposed branch: | lp://staging/~termie/bzr-fastimport/marks_normalization |
Merge into: | lp://staging/bzr-fastimport |
Diff against target: |
61 lines (+6/-6) 4 files modified
branch_updater.py (+1/-0) bzr_commit_handler.py (+1/-1) marks_file.py (+2/-3) processors/generic_processor.py (+2/-2) |
To merge this branch: | bzr merge lp://staging/~termie/bzr-fastimport/marks_normalization |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jelmer Vernooij | Pending | ||
Ian Clatworthy | Pending | ||
Gyorgy Kovacs | Pending | ||
Bazaar Developers | Pending | ||
Review via email:
|
Description of the change
Add a bunch of mark id normalization.
bzr-fastimport is getting marks from a variety of sources, all of which
us the format ':\d+' but it really wants just the raw number internally.
This patch cleans up the symptoms of many places where this normalization
was not occuring.
Testing has been based on using git-bzr-ng (http://
I would love to get this merged soon so that my tool does not need to depend on a patched version of your library :D
To post a comment you must log in.
Hi, thanks for the patch.
It doesn't look wrong, but I'm not familiar enough with the code to say it's obviously right. Are there already tests for this, or could you add some?