Code review comment for lp://staging/~ted/snapcraft/status

Revision history for this message
Leo Arias (elopio) wrote :

Please use logger.info instead of print.
Also for consistency it would be nice if you use single quotes. The code in snapcraft uses single and double quotes, so it would be nice to start changing this practice.

You didn't change this line, but you probably should:

47 except Exception:

I think that what you want to catch in there is the OSError.

And you are missing the tests in this branch. At least for some states it should be easy to write the tests. For some you might need to fake the state, which shouldn't be hard either. Ping me if you need a hand here.

review: Needs Fixing

« Back to merge proposal