Merge lp://staging/~ted/snapcraft/status into lp://staging/~snappy-dev/snapcraft/core
Proposed by
Ted Gould
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~ted/snapcraft/status |
| Merge into: | lp://staging/~snappy-dev/snapcraft/core |
| Diff against target: |
57 lines (+18/-2) 3 files modified
snapcraft/cmds.py (+7/-0) snapcraft/main.py (+3/-0) snapcraft/plugin.py (+8/-2) |
| To merge this branch: | bzr merge lp://staging/~ted/snapcraft/status |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Leo Arias (community) | Needs Fixing | ||
|
Review via email:
|
|||
Commit message
Add status command to query parts
Description of the change
Small 'status' command to find the state of the parts. Working with snapcraft and kept feeling I needed this to figure out what was going on.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Please use logger.info instead of print.
Also for consistency it would be nice if you use single quotes. The code in snapcraft uses single and double quotes, so it would be nice to start changing this practice.
You didn't change this line, but you probably should:
47 except Exception:
I think that what you want to catch in there is the OSError.
And you are missing the tests in this branch. At least for some states it should be easy to write the tests. For some you might need to fake the state, which shouldn't be hard either. Ping me if you need a hand here.