Code review comment for lp://staging/~ted/snapcraft/aws-iot

Revision history for this message
Ted Gould (ted) wrote :

On Thu, 2015-10-29 at 11:48 +0000, Sergio Schvezov wrote:
> > + def _keys_from_local(self, certsdir):
> > + certsjson = None
>
> this shouldn't be needed.
Python is weird. r256
> > === modified file 'snapcraft/plugins/python3.py'
> > --- snapcraft/plugins/python3.py 2015-10-27 19:23:02 +0000
> > +++ snapcraft/plugins/python3.py 2015-10-29 04:34:48 +0000
> > @@ -48,6 +48,15 @@
> > schema['properties']['requirements'] = {
> > 'type': 'string',
> > }
> > + schema['properties']['pip-packages'] = {
> >

>
>
> doesn't this fix the other bug about list of requirements?
>

No, because there are apparently some projects (plainbox) that use
multiple files of requirements. So there's another feature there.

« Back to merge proposal