Merge lp://staging/~ted/snapcraft/aws-iot into lp://staging/~snappy-dev/snapcraft/core

Proposed by Ted Gould
Status: Work in progress
Proposed branch: lp://staging/~ted/snapcraft/aws-iot
Merge into: lp://staging/~snappy-dev/snapcraft/core
Diff against target: 545 lines (+373/-21)
8 files modified
snapcraft/cmds.py (+1/-4)
snapcraft/lifecycle.py (+5/-5)
snapcraft/plugins/awscli.py (+105/-0)
snapcraft/plugins/awsiot.py (+227/-0)
snapcraft/plugins/python2.py (+14/-1)
snapcraft/plugins/python3.py (+14/-1)
snapcraft/tests/test_cmds.py (+6/-9)
snapcraft/tests/test_lifecycle.py (+1/-1)
To merge this branch: bzr merge lp://staging/~ted/snapcraft/aws-iot
Reviewer Review Type Date Requested Status
Sergio Schvezov Needs Fixing
Review via email: mp+276064@code.staging.launchpad.net

Commit message

Add plugins for working with AWS' IoT features

To post a comment you must log in.
lp://staging/~ted/snapcraft/aws-iot updated
252. By Ted Gould

Fix function call

Revision history for this message
Sergio Schvezov (sergiusens) :
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

Looks good, I don't follow, can I see an example for this? I guess that adding the docstring like I ask for can clarify lots here.

review: Needs Fixing
lp://staging/~ted/snapcraft/aws-iot updated
253. By Ted Gould

Testing fixes from Sergio

254. By Ted Gould

Adding docstrings

255. By Ted Gould

Making sure we get more files

Revision history for this message
Sergio Schvezov (sergiusens) wrote :

This looks really good but the need for AWSCLIPlugin I want to avoid.

I still strongly believe that the AWSCLIPlugin should not be needed and a build-package for awscli should be used (we can update the deb in our ppa so we have the IOT option if need be).

Or is there a reason for the aws cli to live in the snap?

There are also some inline comments.

ftr,
$ rmadison awscli
 awscli | 1.2.9-2 | trusty/universe | source, all
 awscli | 1.7.0-1 | vivid/universe | source, all
 awscli | 1.7.0-1build1 | wily/universe | source, all
 awscli | 1.7.0-1build1 | xenial/universe | source, all

review: Needs Fixing
Revision history for this message
Sergio Schvezov (sergiusens) :
Revision history for this message
Sergio Schvezov (sergiusens) :
lp://staging/~ted/snapcraft/aws-iot updated
256. By Ted Gould

Removing unneeded None

Revision history for this message
Ted Gould (ted) wrote :

On Thu, 2015-10-29 at 11:48 +0000, Sergio Schvezov wrote:
> > + def _keys_from_local(self, certsdir):
> > + certsjson = None
>
> this shouldn't be needed.
Python is weird. r256
> > === modified file 'snapcraft/plugins/python3.py'
> > --- snapcraft/plugins/python3.py 2015-10-27 19:23:02 +0000
> > +++ snapcraft/plugins/python3.py 2015-10-29 04:34:48 +0000
> > @@ -48,6 +48,15 @@
> > schema['properties']['requirements'] = {
> > 'type': 'string',
> > }
> > + schema['properties']['pip-packages'] = {
> >

>
>
> doesn't this fix the other bug about list of requirements?
>

No, because there are apparently some projects (plainbox) that use
multiple files of requirements. So there's another feature there.

Unmerged revisions

256. By Ted Gould

Removing unneeded None

255. By Ted Gould

Making sure we get more files

254. By Ted Gould

Adding docstrings

253. By Ted Gould

Testing fixes from Sergio

252. By Ted Gould

Fix function call

251. By Ted Gould

Adding the plugins to the command tests

250. By Ted Gould

Switching to the 'new run'

249. By Ted Gould

Merge trunk

248. By Ted Gould

Reduce complexity of cert gen

247. By Ted Gould

Include cleanups

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: