Code review comment for lp://staging/~ted/indicator-sound/rtm-silent-mode-item

Revision history for this message
Selene ToyKeeper (toykeeper) wrote :

New behavior needs to be covered in the test plan, or in autopilot tests, or in unit tests... depending on which is most appropriate. (and if it's a manual test, it will need to be automated eventually)

http://wiki.ubuntu.com/Process/Merges/TestPlan/indicator-sound

This change does appear to toggle silent mode. However, there are some issues:

- Toggling the indicator checkbox does not affect the checkbox in system-settings.
- The system-settings Sound page disagrees with itself after using the indicator to change the setting: http://toykeeper.net/tmp/phablet/2014-10-22/silent-but-not.png
- Silent mode does not silence dialpad sounds or keyboard click sounds, even though other platforms silence these.
- The test plan should specify which parts of the system should be affected by silent mode and which are not. It only silences incoming calls and incoming SMS ringtones, but has no effect on music, video playback, alarms, dialpad sounds, or keyboard sounds.

« Back to merge proposal