The Sound Menu

Merge lp://staging/~ted/indicator-sound/rtm-silent-mode-item into lp://staging/indicator-sound/rtm-14.09

  1. rtm-silent-mode-item
  2. Merge into trunk.rtm-14.09
Proposed by Ted Gould
Status: Merged
Approved by: Charles Kerr
Approved revision: 461
Merged at revision: 462
Proposed branch: lp://staging/~ted/indicator-sound/rtm-silent-mode-item
Merge into: lp://staging/indicator-sound/rtm-14.09
Prerequisite: lp://staging/~indicator-applet-developers/indicator-sound/rtm-extreme-volume-warning
Diff against target: 499 lines (+228/-44)
10 files modified
data/com.canonical.indicator.sound.gschema.xml (+0/-9)
debian/changelog (+13/-0)
src/CMakeLists.txt (+8/-0)
src/accounts-service-privacy-settings.vala (+26/-0)
src/accounts-service-system-sound-settings.vala (+25/-0)
src/accounts-service-user.vala (+72/-2)
src/media-player-mpris.vala (+1/-1)
src/service.vala (+63/-29)
src/sound-menu.vala (+18/-2)
src/volume-control.vala (+2/-1)
To merge this branch: bzr merge lp://staging/~ted/indicator-sound/rtm-silent-mode-item
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
Review via email: mp+238332@code.staging.launchpad.net

Commit message

Enable silent mode checkbox on RTM

Description of the change

This landed in Utopic, got reverted from rtm, well kinda, just held up. Then another branch got determined to need to land first. So got reverted.

To post a comment you must log in.
lp://staging/~ted/indicator-sound/rtm-silent-mode-item updated
460. By Ted Gould

Merge trunk

461. By Ted Gould

Adding a debian changelog entry

Revision history for this message
Charles Kerr (charlesk) wrote :

Code looks fine and seems to work.

I don't see any specific tests for silent mode in the manual tests, but exploratory testing conducted on mako + rtm r102.

review: Approve
Revision history for this message
Selene ToyKeeper (toykeeper) wrote :

New behavior needs to be covered in the test plan, or in autopilot tests, or in unit tests... depending on which is most appropriate. (and if it's a manual test, it will need to be automated eventually)

http://wiki.ubuntu.com/Process/Merges/TestPlan/indicator-sound

This change does appear to toggle silent mode. However, there are some issues:

- Toggling the indicator checkbox does not affect the checkbox in system-settings.
- The system-settings Sound page disagrees with itself after using the indicator to change the setting: http://toykeeper.net/tmp/phablet/2014-10-22/silent-but-not.png
- Silent mode does not silence dialpad sounds or keyboard click sounds, even though other platforms silence these.
- The test plan should specify which parts of the system should be affected by silent mode and which are not. It only silences incoming calls and incoming SMS ringtones, but has no effect on music, video playback, alarms, dialpad sounds, or keyboard sounds.

Revision history for this message
Charles Kerr (charlesk) wrote :

xref: https://code.launchpad.net/~ted/indicator-sound/silent-mode-test-plan/+merge/239236

Revision history for this message
Selene ToyKeeper (toykeeper) wrote :

Thanks, just wanted to make sure the changes were written... somewhere. The complications in getting it into a published central test plan will hopefully be addressed at a meeting later today.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches