Code review comment for lp://staging/~ted/indicator-sound/indicator-test

Revision history for this message
Jussi Pakkanen (jpakkane) wrote :

Looks fine. The only thing I noticed is that you are passing test information in -Dfoo=bar command line arguments. You might want to reconsider putting them in a testconfig.h instead. This makes it easier to check the status and you don't have to think about quoting your quote characters for the shell.

Up to you if you want to do that though.

review: Approve

« Back to merge proposal