The Sound Menu

Merge lp://staging/~ted/indicator-sound/indicator-test into lp://staging/indicator-sound/15.04

indicator-test
Merge into trunk.15.04

Proposed by Ted Gould on 2014-11-26

Status:	Merged
Approved by:	Ted Gould on 2015-02-05
Approved revision:	509
Merged at revision:	475
Proposed branch:	lp://staging/~ted/indicator-sound/indicator-test
Merge into:	lp://staging/indicator-sound/15.04
Diff against target:	811 lines (+635/-16) 9 files modified CMakeLists.txt (+1/-1) debian/control (+3/-2) debian/rules (+3/-0) tests/CMakeLists.txt (+45/-0) tests/accounts-service-mock.h (+21/-0) tests/accounts-service-user.cc (+1/-2) tests/indicator-fixture.h (+444/-0) tests/indicator-test.cc (+112/-0) tests/media-player-user.cc (+5/-11)
To merge this branch:	bzr merge lp://staging/~ted/indicator-sound/indicator-test
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot (community)	continuous-integration		Approve on 2015-02-04
Jussi Pakkanen (community)		2014-11-26	Approve on 2015-02-03
Review via email: mp+242931@code.staging.launchpad.net

Commit message

Initial support for indicator service testing from the GMenu/GAction interfaces

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-11-26:

FAILED: Continuous integration, rev:491
http://jenkins.qa.ubuntu.com/job/indicator-sound-ci/177/
Executed test runs:
FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-sound-vivid-amd64-ci/4/console
FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-sound-vivid-armhf-ci/4/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-sound-ci/177/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-01-16:

FAILED: Continuous integration, rev:463
http://jenkins.qa.ubuntu.com/job/indicator-sound-ci/182/
Executed test runs:
FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-sound-vivid-amd64-ci/9/console
FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-sound-vivid-armhf-ci/9/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-sound-ci/182/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-01-26:

FAILED: Continuous integration, rev:463
http://jenkins.qa.ubuntu.com/job/indicator-sound-ci/184/
Executed test runs:
FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-sound-vivid-amd64-ci/11/console
FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-sound-vivid-armhf-ci/11/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-sound-ci/184/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Ted Gould (ted) wrote on 2015-01-30:

NOTE: Will fail in Jenkins as it needs a yet unreleased dbus-test-runner:

https://code.launchpad.net/~ted/dbus-test-runner/dbusmock-system-bus/+merge/248072

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-01-30:

FAILED: Continuous integration, rev:503
http://jenkins.qa.ubuntu.com/job/indicator-sound-ci/187/
Executed test runs:
FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-sound-vivid-amd64-ci/14/console
FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-sound-vivid-armhf-ci/14/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-sound-ci/187/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~ted/indicator-sound/indicator-test updated on 2015-02-02

504. By Ted Gould on 2015-02-02: We're not using libaccountservice on this side of things, so we don't need to split

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-02:

FAILED: Continuous integration, rev:504
http://jenkins.qa.ubuntu.com/job/indicator-sound-ci/188/
Executed test runs:
FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-sound-vivid-amd64-ci/15/console
FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-sound-vivid-armhf-ci/15/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-sound-ci/188/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Ted Gould (ted) wrote on 2015-02-03:

NOTE: You need the dbus-test-runner that landed in vivid last night.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-03:

FAILED: Continuous integration, rev:504
http://jenkins.qa.ubuntu.com/job/indicator-sound-ci/190/
Executed test runs:
FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-sound-vivid-amd64-ci/17/console
FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-sound-vivid-armhf-ci/17/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-sound-ci/190/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Jussi Pakkanen (jpakkane) wrote on 2015-02-03:

Looks fine. The only thing I noticed is that you are passing test information in -Dfoo=bar command line arguments. You might want to reconsider putting them in a testconfig.h instead. This makes it easier to check the status and you don't have to think about quoting your quote characters for the shell.

Up to you if you want to do that though.

review: Approve

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-03:

FAILED: Continuous integration, rev:504
http://jenkins.qa.ubuntu.com/job/indicator-sound-ci/192/
Executed test runs:
FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-sound-vivid-amd64-ci/19/console
FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-sound-vivid-armhf-ci/19/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-sound-ci/192/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~ted/indicator-sound/indicator-test updated on 2015-02-04

505. By Ted Gould on 2015-02-04: Make the testing verbose
506. By Ted Gould on 2015-02-04: Compile GSettings schema and use the memory backend

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-04:

FAILED: Continuous integration, rev:505
http://jenkins.qa.ubuntu.com/job/indicator-sound-ci/194/
Executed test runs:
FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-sound-vivid-amd64-ci/21/console
FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-sound-vivid-armhf-ci/21/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-sound-ci/194/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-04:

FAILED: Continuous integration, rev:505
http://jenkins.qa.ubuntu.com/job/indicator-sound-ci/195/
Executed test runs:
FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-sound-vivid-amd64-ci/22/console
FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-sound-vivid-armhf-ci/22/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-sound-ci/195/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~ted/indicator-sound/indicator-test updated on 2015-02-04

507. By Ted Gould on 2015-02-04: Set build dependencies to compile the schemas
508. By Ted Gould on 2015-02-04: Make sure that we have the com.ubuntu.sound settings