Code review comment for lp://staging/~tealeg/landscape-client/monitoring-plugins-scoped-resynch
Revision history for this message
| Geoff Teale (tealeg) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
513534c
demo site
(Get the code!)
> Looks good to me! +1
>
> #1:
> + scope = "openstack"
>
> The scope name seems a bit too specific, as swift and ceph could be used
> outside of an OpenStack deployment.
> Maybe something like "storage"?
Ok, I wasn't very happy with "openstack" anyhow. Storage it is, done!
>
>
> 2:
> This seems like an accidental change.
Yes, indeed. Fixed.