Code review comment for lp://staging/~stolowski/unity/expand-2nd-home-category

Revision history for this message
Michal Hruby (mhr3) wrote :

Can we at least do this when the search actually finishes and not arbitrarily after adding a few results?

Otherwise the category might get expanded, but as another lens finishes search and pushes more results it will again get unexpanded... Or is that what what we actually want?

> lens_->view_type == ViewType::LENS_VIEW

That doesn't look right, we should be using HOME_VIEW in home lens (if that's not the case the id check should suffice)

review: Needs Fixing

« Back to merge proposal