Merge lp://staging/~stolowski/unity/expand-2nd-home-category into lp://staging/unity

Proposed by Paweł Stołowski
Status: Rejected
Rejected by: Andrea Azzarone
Proposed branch: lp://staging/~stolowski/unity/expand-2nd-home-category
Merge into: lp://staging/unity
Diff against target: 161 lines (+59/-18)
4 files modified
dash/DashView.cpp (+11/-0)
dash/LensView.cpp (+30/-15)
dash/LensView.h (+1/-1)
manual-tests/Dash.txt (+17/-2)
To merge this branch: bzr merge lp://staging/~stolowski/unity/expand-2nd-home-category
Reviewer Review Type Date Requested Status
Andrea Azzarone (community) Disapprove
Michal Hruby (community) Needs Fixing
Neil J. Patel Pending
Review via email: mp+126453@code.staging.launchpad.net

Commit message

Dash Home Lens: expand 2nd category (Files & Folders by default) if search is empty.

Description of the change

Dash Home Lens: expand 2nd category (Files & Folders by default) if search is empty.

To post a comment you must log in.
Revision history for this message
Andrea Azzarone (azzar1) wrote :

Do we really need to hardcode it? A category cannot expand itself using libunity etc.?

Revision history for this message
Andrea Azzarone (azzar1) :
review: Needs Information
Revision history for this message
Paweł Stołowski (stolowski) wrote :

Unfortunately there is no way to do this from lenses. Ideally, we should have a new expand-in-home-on-empty-search lens property in libunity Lens class, that would be passed via existing as{v} hints over DBus. I discussed this with Neil and he suggested handling it as an edge case on unity side only, as it's sanest for 12.10.

Revision history for this message
Michal Hruby (mhr3) wrote :

Can we at least do this when the search actually finishes and not arbitrarily after adding a few results?

Otherwise the category might get expanded, but as another lens finishes search and pushes more results it will again get unexpanded... Or is that what what we actually want?

> lens_->view_type == ViewType::LENS_VIEW

That doesn't look right, we should be using HOME_VIEW in home lens (if that's not the case the id check should suffice)

review: Needs Fixing
Revision history for this message
Andrea Azzarone (azzar1) wrote :

> Unfortunately there is no way to do this from lenses. Ideally, we should have
> a new expand-in-home-on-empty-search lens property in libunity Lens class,
> that would be passed via existing as{v} hints over DBus. I discussed this with
> Neil and he suggested handling it as an edge case on unity side only, as it's
> sanest for 12.10.

Got it.

2756. By Paweł Stołowski

Perform category expansion on search finished.

2757. By Paweł Stołowski

Merged trunk.

2758. By Paweł Stołowski

Added manual test for 2nd category expansion in dash home view.

Revision history for this message
Andrea Azzarone (azzar1) :
review: Disapprove

Unmerged revisions

2758. By Paweł Stołowski

Added manual test for 2nd category expansion in dash home view.

2757. By Paweł Stołowski

Merged trunk.

2756. By Paweł Stołowski

Perform category expansion on search finished.

2755. By Paweł Stołowski

Dash Home Lens: expand 2nd category (Files & Folders by default) if search is empty.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.