Code review comment for lp://staging/~stevenk/launchpad/ids-needsbuild

Revision history for this message
Gavin Panella (allenap) wrote :

This confused the hell out of me:

+ if self.distroseries.parent.id == self.parent.parent.id:
+ self._checkBuilds()

until I realised that DistroSeries.parent is a cheeky synonym for
.distribution. Could you consider changing this to use .distribution
instead?

Otherwise, looks good, and I like the way you punctuate :)

review: Approve

« Back to merge proposal