Launchpad itself

Merge lp://staging/~stevenk/launchpad/ids-needsbuild into lp://staging/launchpad

  1. ids-needsbuild
  2. Merge into devel
Proposed by Steve Kowalik
Status: Merged
Approved by: Steve Kowalik
Approved revision: no longer in the source branch.
Merged at revision: 12831
Proposed branch: lp://staging/~stevenk/launchpad/ids-needsbuild
Merge into: lp://staging/launchpad
Diff against target: 179 lines (+33/-18)
2 files modified
lib/lp/soyuz/scripts/initialise_distroseries.py (+2/-1)
lib/lp/soyuz/scripts/tests/test_initialise_distroseries.py (+31/-17)
To merge this branch: bzr merge lp://staging/~stevenk/launchpad/ids-needsbuild
Reviewer Review Type Date Requested Status
Gavin Panella (community) Approve
Review via email: mp+57614@code.staging.launchpad.net

Commit message

[r=allenap][bug=747508] Allow pending builds during IDS if the child is not a series of the parents distribution.

Description of the change

Allow derivation if the parent distroseries has pending builds if and only if the child's distribution is not the same as the parent's. This means they don't share an archive.

I also went mad, and added full stops to every comment that didn't already have them.

To post a comment you must log in.
Revision history for this message
Gavin Panella (allenap) wrote :

This confused the hell out of me:

+ if self.distroseries.parent.id == self.parent.parent.id:
+ self._checkBuilds()

until I realised that DistroSeries.parent is a cheeky synonym for
.distribution. Could you consider changing this to use .distribution
instead?

Otherwise, looks good, and I like the way you punctuate :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.