Code review comment for lp://staging/~sinzui/juju-ci-tools/proxy-env

Revision history for this message
Aaron Bentley (abentley) wrote :

This looks like an improvement. I don't quite follow the logic of raising UndefinedProxyError when http_proxy is defined but different between os.environ and /etc/environment, but it's conservative, so fine.

review: Approve

« Back to merge proposal