Merge lp://staging/~sinzui/juju-ci-tools/proxy-env into lp://staging/juju-ci-tools
Proposed by
Curtis Hovey
| Status: | Merged |
|---|---|
| Merged at revision: | 1660 |
| Proposed branch: | lp://staging/~sinzui/juju-ci-tools/proxy-env |
| Merge into: | lp://staging/juju-ci-tools |
| Diff against target: |
189 lines (+104/-5) 2 files modified
assess_proxy.py (+52/-0) tests/test_assess_proxy.py (+52/-5) |
| To merge this branch: | bzr merge lp://staging/~sinzui/juju-ci-tools/proxy-env |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Aaron Bentley (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Raise an error when the current env or /etc/environment does not define proxy info.
This branch add a helper that verifies there is enough proxy information defined in the client's env and in /etc/environment to run tests.
This branch strongly hints at what went wrong in my testing this morning when I reset the host.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This looks like an improvement. I don't quite follow the logic of raising UndefinedProxyError when http_proxy is defined but different between os.environ and /etc/environment, but it's conservative, so fine.