Code review comment for lp://staging/~sil2100/merge-o-matic/exclude-pkgs-from-stats
Revision history for this message
| Brian Murray (brian-murray) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
9199653
demo site
(Get the code!)
> Two things:
>
> 1) I download the exclude list in cron.daily as I saw this is what's done for
> the blacklist. Makes more sense than having it local-only or in the source
> tree.
> 2) I was considering adding a new, separate count of 'excluded' but I couldn't
> find any real use for something like that. There's always risk of one
> forgetting that some packages are excluded, yes, but the exclude file should
> anyway be always kept up-to-date.
I think the excluded count would be easy to add and doesn't cost anything, additionally it'd be useful to have this count for grafana because if it is grows a bunch something could be wrong.