Merge-o-Matic

Merge lp://staging/~sil2100/merge-o-matic/exclude-pkgs-from-stats into lp://staging/merge-o-matic

  1. exclude-pkgs-from-stats
  2. Merge into trunk
Proposed by Łukasz Zemczak
Status: Merged
Merged at revision: 301
Proposed branch: lp://staging/~sil2100/merge-o-matic/exclude-pkgs-from-stats
Merge into: lp://staging/merge-o-matic
Diff against target: 162 lines (+98/-1)
3 files modified
cron.daily (+1/-1)
data/foundations.exclude (+65/-0)
stats.py (+32/-0)
To merge this branch: bzr merge lp://staging/~sil2100/merge-o-matic/exclude-pkgs-from-stats
Reviewer Review Type Date Requested Status
Steve Langasek Approve
Brian Murray Approve
Review via email: mp+335387@code.staging.launchpad.net

Commit message

Experimental try on adding a 'soft blacklist' for excluding certain packages only from m-o-m statistics.

Description of the change

Experimental try on adding a 'soft blacklist' for excluding certain packages only from m-o-m statistics.

This is useful since when generating statistics for some teams, some packages might not be relevant for merging. In the Foundations team we would like to omit those in the statistics which we use for graphing our KPIs.

To post a comment you must log in.
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Two things:

1) I download the exclude list in cron.daily as I saw this is what's done for the blacklist. Makes more sense than having it local-only or in the source tree.
2) I was considering adding a new, separate count of 'excluded' but I couldn't find any real use for something like that. There's always risk of one forgetting that some packages are excluded, yes, but the exclude file should anyway be always kept up-to-date.

Revision history for this message
Brian Murray (brian-murray) wrote :

> Two things:
>
> 1) I download the exclude list in cron.daily as I saw this is what's done for
> the blacklist. Makes more sense than having it local-only or in the source
> tree.
> 2) I was considering adding a new, separate count of 'excluded' but I couldn't
> find any real use for something like that. There's always risk of one
> forgetting that some packages are excluded, yes, but the exclude file should
> anyway be always kept up-to-date.

I think the excluded count would be easy to add and doesn't cost anything, additionally it'd be useful to have this count for grafana because if it is grows a bunch something could be wrong.

Revision history for this message
Brian Murray (brian-murray) wrote :

One in-line comment.

lp://staging/~sil2100/merge-o-matic/exclude-pkgs-from-stats updated
303. By Łukasz Zemczak

Remove unnecessary conditional for read_excluded_packages()

304. By Łukasz Zemczak

Add an 'excluded' statistic to keep track of the number of explicitly exluded packages from the stats.

Revision history for this message
Brian Murray (brian-murray) wrote :

Okay, this seems good to me.

review: Approve
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

I also prepared a list of d-i packages to exclude for foundations. I do not have access to snakefruit so I can't get it in place, but once I get someone who can validate the list and put it up, this branch here will be good for production.

You can see the list here:
http://people.canonical.com/~lzemczak/foundations.exclude-mom

lp://staging/~sil2100/merge-o-matic/exclude-pkgs-from-stats updated
305. By Łukasz Zemczak

Switch to shipping the exclude list in MoM bzr, add initial version of the foundations blacklist.

306. By Łukasz Zemczak

I guess it's better if we have a separate directory for 'static' files like the exclude list.

Revision history for this message
Brian Murray (brian-murray) wrote :

Waiting for slangasek's approval of the exclude list.

lp://staging/~sil2100/merge-o-matic/exclude-pkgs-from-stats updated
307. By Łukasz Zemczak

Slightly trim down the exclude list.

Revision history for this message
Steve Langasek (vorlon) wrote :

I have discussed the particulars of this blacklist with Łukasz, and this has my +1. We may want to extend the list further later as a result of manual analysis, but this is a correct starting point with no false-positives.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: