Code review comment for lp://staging/~sidnei/zope.testing/parallel-layer-teardown

Revision history for this message
Tres Seaver (tseaver) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Sidnei da Silva wrote:
> Sidnei da Silva has proposed merging lp:~sidnei/zope.testing/parallel-layer-teardown into lp:zope.testing.
>
> Requested reviews:
> ZTK steering group (ztk-steering-group)
>
>
> - When layers were run in parallel, their tearDown was not
> called. Additionally, the first layer which was run in the main
> thread did not have it's tearDown called either.

Bot fixes look reasonable to me.

I'm sad to see more extraneious noise in the output, but that is a
different issue: I think the layer setup / teardown output should be
suppressed at "normal" verbosity levels.

+1 to merge both.

Tres.
- --
===================================================================
Tres Seaver +1 540-429-0999 <email address hidden>
Palladion Software "Excellence by Design" http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkvsImQACgkQ+gerLs4ltQ7G9QCfV6tWq8fgtfCbcQL5pR1j+JEj
AE8AnjKJommnlXMEKTU5FaCceUH17qUq
=5dRs
-----END PGP SIGNATURE-----

« Back to merge proposal