Merge lp://staging/~sidnei/zope.testing/parallel-layer-teardown into lp://staging/zope.testing

Proposed by Sidnei da Silva
Status: Merged
Approved by: Sidnei da Silva
Approved revision: 367
Merge reported by: Sidnei da Silva
Merged at revision: not available
Proposed branch: lp://staging/~sidnei/zope.testing/parallel-layer-teardown
Merge into: lp://staging/zope.testing
Diff against target: 132 lines (+38/-10)
4 files modified
CHANGES.txt (+3/-0)
src/zope/testing/testrunner/runner.py (+11/-10)
src/zope/testing/testrunner/testrunner-layers-buff.txt (+3/-0)
src/zope/testing/testrunner/testrunner-layers.txt (+21/-0)
To merge this branch: bzr merge lp://staging/~sidnei/zope.testing/parallel-layer-teardown
Reviewer Review Type Date Requested Status
Sidnei da Silva Approve
Review via email: mp+25151@code.staging.launchpad.net

Description of the change

- When layers were run in parallel, their tearDown was not
  called. Additionally, the first layer which was run in the main
  thread did not have it's tearDown called either.

To post a comment you must log in.
Revision history for this message
Tres Seaver (tseaver) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Sidnei da Silva wrote:
> Sidnei da Silva has proposed merging lp:~sidnei/zope.testing/parallel-layer-teardown into lp:zope.testing.
>
> Requested reviews:
> ZTK steering group (ztk-steering-group)
>
>
> - When layers were run in parallel, their tearDown was not
> called. Additionally, the first layer which was run in the main
> thread did not have it's tearDown called either.

Bot fixes look reasonable to me.

I'm sad to see more extraneious noise in the output, but that is a
different issue: I think the layer setup / teardown output should be
suppressed at "normal" verbosity levels.

+1 to merge both.

Tres.
- --
===================================================================
Tres Seaver +1 540-429-0999 <email address hidden>
Palladion Software "Excellence by Design" http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkvsImQACgkQ+gerLs4ltQ7G9QCfV6tWq8fgtfCbcQL5pR1j+JEj
AE8AnjKJommnlXMEKTU5FaCceUH17qUq
=5dRs
-----END PGP SIGNATURE-----

Revision history for this message
Sidnei da Silva (sidnei) wrote :

Actually, there's no extra *new* noise. If you look at the tests, you'll see that the tearDown messages were printed just right when not running in parallel. The bug was exactly that it was not running the tearDown when in parallel, so the messages were not printed because the code was never executed.

I like the idea of suppressing those messages when the verbosity is low. I've opened Bug #580072 to track it.

Revision history for this message
Sidnei da Silva (sidnei) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches